Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: commnet out sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: commnet out sd card detect gpio
We still need to update gpio definition for jasperlake soc. We will update correct gpio for sd card detect once we have jasperlake soc gpio patch.
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38259/1
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb index 76ceb30..8976d9b 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb @@ -159,7 +159,7 @@ register "dptf_enable" = "1"
# GPIO for SD card detect - register "sdcard_cd_gpio" = "GPP_G5" + # register "sdcard_cd_gpio" = "GPP_G5"
# Enable S0ix register "s0ix_enable" = "0"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: commnet out sd card detect gpio ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG@7 PS1, Line 7: commnet Comment
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG@9 PS1, Line 9: jasperlake Jasper Lake
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38259
to look at the new patch set (#2).
Change subject: mb/intel/jasperlake_rvp: Commnet out sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Commnet out sd card detect gpio
We still need to update gpio definition for Jasper Lake soc. We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38259/2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Commnet out sd card detect gpio ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG@7 PS1, Line 7: commnet
Comment
Done
https://review.coreboot.org/c/coreboot/+/38259/1//COMMIT_MSG@9 PS1, Line 9: jasperlake
Jasper Lake
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Commnet out sd card detect gpio ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/2//COMMIT_MSG@7 PS2, Line 7: Commnet Comment?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38259
to look at the new patch set (#3).
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Comment out sd card detect gpio
We still need to update gpio definition for Jasper Lake soc. We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38259/3
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/2//COMMIT_MSG@7 PS2, Line 7: Commnet
Comment?
Done
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl... PS3, Line 162: # register "sdcard_cd_gpio" = "GPP_G5" good practice would be add TODO section here to tell the problem why you have commented this code
Hello Subrata Banik, Aamir Bohra, Ronak Kanabar, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38259
to look at the new patch set (#4).
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Comment out sd card detect gpio
Tigerlake SoC doesn't have GPIO defined for GPP_G. so compilation is failing due to this. TODO: We still need to update gpio definition for Jasper Lake soc. We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38259/4
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/3/src/mainboard/intel/jasperl... PS3, Line 162: # register "sdcard_cd_gpio" = "GPP_G5"
good practice would be add TODO section here to tell the problem why you have commented this code
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 4: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 4: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 4: Code-Review+2
Adding again is tracked here: https://ticket.coreboot.org/issues/251
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@7 PS4, Line 7: Commen I'm asking that we remove the commented-out code before merge, so how about we change this to something like "Removed declaration of sdcard_cd_gpio" ?
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@11 PS4, Line 11: TODO: We still need to update gpio definition for Jasper Lake soc. : We will update correct gpio for sd card detect once we have Jasper Lake : soc gpio patch. : Please remove TODO and create a bug to track this work and add the bug number to the comments in this CL for future reference. Thanks.
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 162: # TODO: Replace with correct GPIO definition once gpio_soc_defs.h is Please remove TODO and create a bug for tracking that work and add the bug number to the CL comments for future tracking purposes. Thanks.
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 164: # register "sdcard_cd_gpio" = "GPP_G5" Please remove commented-out code.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Comment out sd card detect gpio ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@15 PS4, Line 15: Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Please add a section something like this:
BUG=b:<bug_number_being_fixed_by_this_change> BRANCH=none TEST=Verify "emerge-jasperlake_rvp coreboot" builds successfully.
Hello Srinidhi N Kaushik, Subrata Banik, Aamir Bohra, Ronak Kanabar, Wonkyu Kim, Rizwan Qureshi, Shaunak Saha, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38259
to look at the new patch set (#5).
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Remove sd card detect gpio
Tigerlake SoC doesn't have GPIO defined for GPP_G. so compilation is failing due to this.
We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
partner bug for tracking: https://ticket.coreboot.org/issues/251
BUG=None BRANCH=NONE TEST='jslrvp' mainboard builds successfully
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38259/5
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@7 PS4, Line 7: Commen
I'm asking that we remove the commented-out code before merge, so how about we change this to someth […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@11 PS4, Line 11: TODO: We still need to update gpio definition for Jasper Lake soc. : We will update correct gpio for sd card detect once we have Jasper Lake : soc gpio patch. :
Please remove TODO and create a bug to track this work and add the bug number to the comments in thi […]
Ack
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@15 PS4, Line 15: Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017
Please add a section something like this: […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 162: # TODO: Replace with correct GPIO definition once gpio_soc_defs.h is
Please remove TODO and create a bug for tracking that work and add the bug number to the CL comments […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 164: # register "sdcard_cd_gpio" = "GPP_G5"
Please remove commented-out code.
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
Patch Set 5: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Remove sd card detect gpio
Tigerlake SoC doesn't have GPIO defined for GPP_G. so compilation is failing due to this.
We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
partner bug for tracking: https://ticket.coreboot.org/issues/251
BUG=None BRANCH=NONE TEST='jslrvp' mainboard builds successfully
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38259 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb index 76ceb30..b4ed697 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb @@ -158,9 +158,6 @@ # Enable DPTF register "dptf_enable" = "1"
- # GPIO for SD card detect - register "sdcard_cd_gpio" = "GPP_G5" - # Enable S0ix register "s0ix_enable" = "0"
-
Aamir Bohra (Code Review) -
HAOUAS Elyes (Code Review)
-
Maulik V Vaghela (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)
-
Wonkyu Kim (Code Review)