HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23386 )
Change subject: drivers/intel/fsp2_0: Add support to display FSP version info Hob
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/23386/10/src/drivers/intel/fsp2_0/h...
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/23386/10/src/drivers/intel/fsp2_0/h...
PS10, Line 238: size -= sizeof(SMBIOS_STRUCTURE);
Not used
https://review.coreboot.org/c/coreboot/+/23386/10/src/drivers/intel/fsp2_0/h...
PS10, Line 274: str_ptr = (char *)((uintptr_t)str_ptr + cnt +
: sizeof(uint8_t));
this is a same as at line #269
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib749e49a9f263d85947b60d4c445faf8c37f5931
Gerrit-Change-Number: 23386
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 20 Oct 2019 07:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment