Attention is currently required from: Felix Singer, Jan Philipp Groß, Máté Kukri, Paul Menzel.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email )
Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell) ......................................................................
Patch Set 9: Code-Review+2
(4 comments)
File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig:
https://review.coreboot.org/c/coreboot/+/82913/comment/8c4675b0_954d4fc3?usp... : PS9, Line 1: ## SPDX-License-Identifier: GPL-2.0-only Add newline
File src/mainboard/asrock/fatal1ty_z87_professional/bootblock.c:
https://review.coreboot.org/c/coreboot/+/82913/comment/d8badf5b_846a27e4?usp... : PS9, Line 7: { I never got around to look into this
File src/mainboard/asrock/fatal1ty_z87_professional/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/82913/comment/bdca3f4e_b20f6c96?usp... : PS9, Line 3: Drop newline
File src/mainboard/asrock/fatal1ty_z87_professional/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/82913/comment/69f913f4_2de60790?usp... : PS9, Line 20: Drop newline