Change in coreboot[master]: nb/intel/ironlake: Introduce memmap.h

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48235 )

Change subject: nb/intel/ironlake: Introduce memmap.h
......................................................................

nb/intel/ironlake: Introduce memmap.h

Inspired by Idca25b2e4bf65abcb and Ib275f9ad8ca9ff move all memory map
definitions into a header with a common name.

Change-Id: I5d8a3df4d18cad89de17d3842d28ab8695e2b139
Signed-off-by: Patrick Georgi 
---
M src/northbridge/intel/ironlake/ironlake.h
A src/northbridge/intel/ironlake/memmap.h
2 files changed, 24 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/48235/1

diff --git a/src/northbridge/intel/ironlake/ironlake.h b/src/northbridge/intel/ironlake/ironlake.h
index 86c6054..0a0c295 100644
--- a/src/northbridge/intel/ironlake/ironlake.h
+++ b/src/northbridge/intel/ironlake/ironlake.h
@@ -3,12 +3,7 @@
 #ifndef __NORTHBRIDGE_INTEL_IRONLAKE_IRONLAKE_H__
 #define __NORTHBRIDGE_INTEL_IRONLAKE_IRONLAKE_H__

-#define DEFAULT_HECIBAR		((u8 *)0xfed17000)
-
-#define IOMMU_BASE1 0xfed90000
-#define IOMMU_BASE2 0xfed91000
-#define IOMMU_BASE3 0xfed92000
-#define IOMMU_BASE4 0xfed93000
+#include "memmap.h"

/*
  * D1:F0 PEG
@@ -24,16 +19,6 @@
 #define IRONLAKE_DESKTOP	1
 #define IRONLAKE_SERVER		2

-/* Northbridge BARs */
-#ifndef __ACPI__
-#define DEFAULT_MCHBAR		((u8 *)0xfed10000)	/* 16 KB */
-#define DEFAULT_DMIBAR		((u8 *)0xfed18000)	/* 4 KB */
-#else
-#define DEFAULT_MCHBAR		0xfed10000	/* 16 KB */
-#define DEFAULT_DMIBAR		0xfed18000	/* 4 KB */
-#endif
-#define DEFAULT_EPBAR		0xfed19000	/* 4 KB */
-
 #define QUICKPATH_BUS 0xff

#include <southbridge/intel/ibexpeak/pch.h>
diff --git a/src/northbridge/intel/ironlake/memmap.h b/src/northbridge/intel/ironlake/memmap.h
new file mode 100644
index 0000000..77ed251
--- /dev/null
+++ b/src/northbridge/intel/ironlake/memmap.h
@@ -0,0 +1,23 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef __NORTHBRIDGE_INTEL_IRONLAKE_MEMMAP_H__
+#define __NORTHBRIDGE_INTEL_IRONLAKE_MEMMAP_H__
+
+#define DEFAULT_HECIBAR		((u8 *)0xfed17000)
+
+#define IOMMU_BASE1 0xfed90000
+#define IOMMU_BASE2 0xfed91000
+#define IOMMU_BASE3 0xfed92000
+#define IOMMU_BASE4 0xfed93000
+
+/* Northbridge BARs */
+#ifndef __ACPI__
+#define DEFAULT_MCHBAR		((u8 *)0xfed10000)	/* 16 KB */
+#define DEFAULT_DMIBAR		((u8 *)0xfed18000)	/* 4 KB */
+#else
+#define DEFAULT_MCHBAR		0xfed10000	/* 16 KB */
+#define DEFAULT_DMIBAR		0xfed18000	/* 4 KB */
+#endif
+#define DEFAULT_EPBAR		0xfed19000	/* 4 KB */
+
+#endif

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48235 )

Change subject: nb/intel/ironlake: Introduce memmap.h
......................................................................

Patch Set 1:

This is a duplicate of CB:45379

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48235 )

Change subject: nb/intel/ironlake: Introduce memmap.h
......................................................................

Patch Set 1:
> Patch Set 1:
>
> This is a duplicate of CB:45379

Well, not a duplicate, but I'd prefer that commit and its predecessor instead.

[Patrick Georgi (Code Review)]

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48235 )

Change subject: nb/intel/ironlake: Introduce memmap.h
......................................................................

Abandoned

let's go for Angel's approach once we know where the binary differences stem from and what they mean