Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME USD based on config ......................................................................
soc/intel/tigerlake: Set TME USD based on config
Set TmeEnable FSP-M upd based on config.
Test: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432 --- M src/soc/intel/tigerlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45486/1
diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c index 2ba276d..70e322c 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params.c @@ -208,6 +208,9 @@ /* Skip CPU side PCIe enablement in FSP if device is disabled in devicetree */ dev = pcidev_path_on_root(SA_DEVFN_CPU_PCIE); m_cfg->CpuPcieRpEnableMask = dev && dev->enabled; + + /* Change TmeEnable UPD value according to ENABLE_TME Kconfig */ + m_cfg->TmeEnable = CONFIG(INTEL_TME); }
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45486
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Set TME USD based on config ......................................................................
soc/intel/tigerlake: Set TME USD based on config
Set TmeEnable FSP-M upd based on config.
Test: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432 --- M src/soc/intel/tigerlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45486/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45486
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
soc/intel/tigerlake: Set TME upd param based on config
Set TmeEnable FSP-M upd based on config.
Test: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432 --- M src/soc/intel/tigerlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45486/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
Patch Set 3: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG@9 PS3, Line 9: Set Enable
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG@11 PS3, Line 11: Test: TEST=
Hello build bot (Jenkins), Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45486
to look at the new patch set (#4).
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
soc/intel/tigerlake: Set TME upd param based on config
Set TmeEnable FSP-M upd based on config.
TEST: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432 --- M src/soc/intel/tigerlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45486/4
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG@9 PS3, Line 9: Set
Enable
i am literally setting, so it could be enable or disable.
https://review.coreboot.org/c/coreboot/+/45486/3//COMMIT_MSG@11 PS3, Line 11: Test:
TEST=
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME upd param based on config ......................................................................
soc/intel/tigerlake: Set TME upd param based on config
Set TmeEnable FSP-M upd based on config.
TEST: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/tigerlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c index 3957299..dc9caee 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params.c @@ -211,6 +211,9 @@ /* Skip CPU side PCIe enablement in FSP if device is disabled in devicetree */ dev = pcidev_path_on_root(SA_DEVFN_CPU_PCIE); m_cfg->CpuPcieRpEnableMask = dev && dev->enabled; + + /* Change TmeEnable UPD value according to INTEL_TME Kconfig */ + m_cfg->TmeEnable = CONFIG(INTEL_TME); }
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)