Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and encoding ......................................................................
Documentation: Fix table and encoding
There's some encoding issue that vim automatically resolved and the table wasn't pretty enough so sphinx complained.
Change-Id: I6c16a3a1fcc306d0b12043ebec7d4e69e9339d7d Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/37642/1
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index 9b9f33b..d008a72 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -2,7 +2,7 @@
This page describes how to run coreboot on the Facebook Monolith.
-Please note: the coreboot implementation for this boards is in it's Alpha state and isn't fully +Please note: the coreboot implementation for this boards is in it's Alpha state and isn't fully tested yet.
## Required blobs @@ -63,7 +63,7 @@
```eval_rst +------------------+--------------------------------------------------+ -| SoC | Intel Kaby Lake U | +| SoC | Intel Kaby Lake U | +------------------+--------------------------------------------------+ | CPU | Intel i3-7100U | +------------------+--------------------------------------------------+
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37642
to look at the new patch set (#2).
Change subject: Documentation: Fix table and layout ......................................................................
Documentation: Fix table and layout
The table wasn't pretty enough so sphinx complained, while the second paragraph had trailing whitespace, could be wrapped differently and also came with a typo.
Change-Id: I6c16a3a1fcc306d0b12043ebec7d4e69e9339d7d Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/37642/2
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and layout ......................................................................
Patch Set 2: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and layout ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and layout ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and layout ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37642 )
Change subject: Documentation: Fix table and layout ......................................................................
Documentation: Fix table and layout
The table wasn't pretty enough so sphinx complained, while the second paragraph had trailing whitespace, could be wrapped differently and also came with a typo.
Change-Id: I6c16a3a1fcc306d0b12043ebec7d4e69e9339d7d Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37642 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Wim Vervoorn: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index 9b9f33b..a469a84 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -2,8 +2,8 @@
This page describes how to run coreboot on the Facebook Monolith.
-Please note: the coreboot implementation for this boards is in it's Alpha state and isn't fully -tested yet. +Please note: the coreboot implementation for this boards is in its +Alpha state and isn't fully tested yet.
## Required blobs
@@ -63,7 +63,7 @@
```eval_rst +------------------+--------------------------------------------------+ -| SoC | Intel Kaby Lake U | +| SoC | Intel Kaby Lake U | +------------------+--------------------------------------------------+ | CPU | Intel i3-7100U | +------------------+--------------------------------------------------+
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)