[M] Change in coreboot[main]: device: Add support for multiple PCI segment groups

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lance Zhao, Matt DeVillier, Tim Chu, Tim Wawrzynczak.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79927?usp=email )

Change subject: device: Add support for multiple PCI segment groups
......................................................................

Patch Set 9: Code-Review+1

(1 comment)

File src/device/device_const.c:

https://review.coreboot.org/c/coreboot/+/79927/comment/e85fda72_7fa6cd9a :
PS7, Line 233: 						   pci_devfn_t devfn)
TBH, I don't think this is a good idea. There are cases where looking up
devices by bus numbers is unavoidable, e.g. external programs device/oprom/
etc. But I wouldn't want to encourage usage by adding more APIs. (Also, the
implementation below looks very questionable: starts with pci_root_bus()
but still walks the global device list).

The code is not wrong, though, so I'll leave this resolved.