Attention is currently required from: Derek Huang, Paul Menzel, Kapil Porwal, Andrey Petrov.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74783 )
Change subject: soc/intel/common: Introduce API to get the FSP Reset Status
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74783/comment/0988665e_26343785
PS2, Line 14: Ideally FSP API should be able to return the status (both success and
: error code) upon exiting the FSP API but unfortunately there are some
: scenarios in ADL/RPL FSP where MultiPhaseSiInit API is unable to return
: any ERROR status. Hence, this function provides an additional hook to
: read the FSP reset status by reading the dedicated HOB without relying
: on the FSP API exit status code.
Is there an FSP upstream bug report for this? If yes, it’d be great if you referenced it.
the bug being mentioned in the commit msg is the own assigned to Intel and there will be external communication from Intel
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief5d79736cc11a0a31ca2889128285795f8b5aae
Gerrit-Change-Number: 74783
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 11:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment