Change in coreboot[master]: soc/amd/picasso: implement and use mca_is_valid_bank - coreboot-gerrit

13 Jul 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56275 )
Change subject: soc/amd/picasso: implement and use mca_is_valid_bank
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56275/comment/cd7fc9fe_9ca3de74 
PS1, Line 197: continue
Should we print a warning saying that bank is not valid?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c7f3066afd220e6b8bf8308a321189d7a2679f6
Gerrit-Change-Number: 56275
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 13 Jul 2021 20:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment