Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80141?usp=email )
Change subject: mb/google/puff: Baseboard devicetree clean up #1
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/puff/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80141/comment/01c1877f_29b8b266 :
PS1, Line 321: device ref p2sb on end
AFAIK P2SB is hidden by the FSP, that's why we set it in chipset.cb
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80141?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a515f13df1252ed2b769a535da22a523c95c359
Gerrit-Change-Number: 80141
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Fri, 26 Jan 2024 15:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment