Hao Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48951 )
Change subject: mb/google/volteer: Add GPIO to copano support
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48951/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/copano/gpio.c:
https://review.coreboot.org/c/coreboot/+/48951/3/src/mainboard/google/voltee...
PS3, Line 189: static const struct pad_config early_gpio_table[] = {
Please add this change to this table: https://chromium-review.googlesource. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0f730c9865ed77c7071245b071315a9c6ea4c8
Gerrit-Change-Number: 48951
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 05 Jan 2021 03:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment