Change in coreboot[master]: cpu,soc/amd: Consolidate smm_lock() - coreboot-gerrit

8 Jul 2020


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42363 )
Change subject: cpu,soc/amd: Consolidate smm_lock()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42363/2/src/cpu/amd/smm/smram_lock.... 
File src/cpu/amd/smm/smram_lock.c:
https://review.coreboot.org/c/coreboot/+/42363/2/src/cpu/amd/smm/smram_lock.... 
PS2, Line 13: 	if (hwcr.lo & SMM_LOCK) /* Skip if already locked, avoid GPF */
...
Felix, Marshall: Can you check this and maybe improve the header? […]
Done. see CB:43309
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/42363
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993bac03d100644a35e6546d40adea1079292d5a
Gerrit-Change-Number: 42363
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jul 2020 22:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment