Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36053 )
Change subject: postcar: Fix linking error with disabled postcar console ......................................................................
postcar: Fix linking error with disabled postcar console
Link files to provide snprintf used by VBOOT code.
Change-Id: I040c3952c22893da5aae11b20a618aa4006c6c58 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/console/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/36053/1
diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc index 3311849..2154eb9 100644 --- a/src/console/Makefile.inc +++ b/src/console/Makefile.inc @@ -23,7 +23,8 @@ romstage-y += post.c romstage-y += die.c
-postcar-$(CONFIG_POSTCAR_CONSOLE) += vtxprintf.c printk.c vsprintf.c +postcar-y += vtxprintf.c vsprintf.c +postcar-$(CONFIG_POSTCAR_CONSOLE) += printk.c postcar-$(CONFIG_POSTCAR_CONSOLE) += init.c console.c postcar-y += post.c postcar-y += die.c
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36053 )
Change subject: postcar: Fix linking error with disabled postcar console ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36053 )
Change subject: postcar: Fix linking error with disabled postcar console ......................................................................
Patch Set 1: Code-Review+2
Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36053 )
Change subject: postcar: Fix linking error with disabled postcar console ......................................................................
postcar: Fix linking error with disabled postcar console
Link files to provide snprintf used by VBOOT code.
Change-Id: I040c3952c22893da5aae11b20a618aa4006c6c58 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36053 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/console/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc index 3311849..2154eb9 100644 --- a/src/console/Makefile.inc +++ b/src/console/Makefile.inc @@ -23,7 +23,8 @@ romstage-y += post.c romstage-y += die.c
-postcar-$(CONFIG_POSTCAR_CONSOLE) += vtxprintf.c printk.c vsprintf.c +postcar-y += vtxprintf.c vsprintf.c +postcar-$(CONFIG_POSTCAR_CONSOLE) += printk.c postcar-$(CONFIG_POSTCAR_CONSOLE) += init.c console.c postcar-y += post.c postcar-y += die.c
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)