Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58184 )
Change subject: mb/google/sarien: Add default fmap for non-ChromeOS builds ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/sarien/default.fmd:
PS2:
Does it? Usually coreboot doesn't need to know about non-coreboot […]
would you prefer it was dropped?
File src/mainboard/google/sarien/default.fmd:
https://review.coreboot.org/c/coreboot/+/58184/comment/3e529578_08e6979b PS3, Line 15: RO_VPD 0x4000
Shouldn't this be left where the original data resides? Or should everybody […]
I suppose I could try to make it align and add (PRESERVE). 99% of people flashing ChromeOS devices are doing so with my firmware and my tools, so it's persisted automatically. And for most CrOS boards, building from upstream coreboot doesn't even include the RO_VPD region. Heck, it wasn't even an option until I added it
-
Matt DeVillier (Code Review)