[S] Change in coreboot[master]: cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS - coreboot-gerrit

7 Apr 2023


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73449 )
Change subject: cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
...
Is this a good idea? The SI prefix seems to be applied to mostly Intel boards. […]
I also don't understand this: how could the auto-generated region match what
`ifdtool --validate` expects? I guess it would only work with specific, manual
configurations.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55eddfb5641b3011d4525893604ccf87fa05a1e2
Gerrit-Change-Number: 73449
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 12:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment