Attention is currently required from: Chen Wisley, Paul Menzel.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57204 )
Change subject: mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57204/comment/79df1f61_7b10598f
PS3, Line 9: Drawper change LTE reset pin from GPP_H0 to GPP_H17 from DVT phase.
The LTE function work, but failed to update lte firmware.
clarified in the issue and comment, let me resolve this thread in order to get this CL merged next week. Thank you!
```
The reason is that fibocom fw updater will assert GPP_H17 (GPIO349) for dedede series and do update LTE fw. Because drawper use GPP_H0 as rese pin, so it failed to update firmware. so, we follow other dedede series, and change to GPP_H17.
```
If anything is still not clear, feel free to comment :)
Patchset:
PS3:
Hi Karthik, […]
Karthik provided CR+2. Thanks!~
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib65580babf7d21535df2bd8d33bb19261bebfe15
Gerrit-Change-Number: 57204
Gerrit-PatchSet: 4
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 04 Sep 2021 13:44:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: Chen Wisley
wisley.chen@quantatw.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment