Change in ...coreboot[master]: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5 - coreboot-gerrit

3 Apr 2019


      Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29796 )
Change subject: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29796/2//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/#/c/29796/2//COMMIT_MSG@11 
PS2, Line 11: BUG=b:124197348
...
See comment3 below. for scenario 2, need setting GPP_B4 to low in S5. Thanks. […]
Thank you.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65deb33a45fdc0c0ce64deaa29c2790029dc1d12
Gerrit-Change-Number: 29796
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Apr 2019 15:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment