Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86070?usp=email )
Change subject: soc/mediatek/mt8196: Add vcore DVFS settings ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86070/comment/ae38b968_6ee99ad6?usp... : PS1, Line 9: so that
https://review.coreboot.org/c/coreboot/+/86070/comment/7325aee7_bcb0a5f1?usp... : PS1, Line 9: tinsys `tinysys`?
https://review.coreboot.org/c/coreboot/+/86070/comment/39a410a5_b38b211a?usp... : PS1, Line 9: ccore `vcore`?
File src/soc/mediatek/mt8196/include/soc/mtk_vcore_opp.h:
https://review.coreboot.org/c/coreboot/+/86070/comment/2e449364_c6d52695?usp... : PS1, Line 8: Explain what "opp" means.
https://review.coreboot.org/c/coreboot/+/86070/comment/b8acb4ff_c6d29098?usp... : PS1, Line 9: extern remove
File src/soc/mediatek/mt8196/mtk_vcore_opp.c:
PS1: Drop `mtk_` from the file name. Does it make sense to rename this to `dvfsrc.c`?