Change in coreboot[master]: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Arthur Heymans (Code Review)

20 Nov 2019 20 Nov '19

10:26 p.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support

Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/uart/oxpcie_early.c 1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37041/1

diff --git a/src/drivers/uart/oxpcie_early.c b/src/drivers/uart/oxpcie_early.c index f6b4040..17f9868 100644 --- a/src/drivers/uart/oxpcie_early.c +++ b/src/drivers/uart/oxpcie_early.c @@ -14,12 +14,11 @@ #include <stdint.h> #include <stddef.h> #include <device/pci_ops.h> -#include <arch/early_variables.h> #include <console/uart.h> #include <device/pci.h> #include <device/pci_def.h>

-static unsigned int oxpcie_present CAR_GLOBAL; +static unsigned int oxpcie_present; static DEVTREE_CONST u32 uart0_base = CONFIG_EARLY_PCI_MMIO_BASE + 0x1000;

int pci_early_device_probe(u8 bus, u8 dev, u32 mmio_base) @@ -58,13 +57,13 @@ reg16 |= PCI_COMMAND_MEMORY; pci_s_write_config16(device, PCI_COMMAND, reg16);

- car_set_var(oxpcie_present, 1); + oxpcie_present = 1; return 0; }

static int oxpcie_uart_active(void) { - return (car_get_var(oxpcie_present)); + return (oxpcie_present); }

uintptr_t uart_platform_base(int idx)

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

build bot (Jenkins) (Code Review)

20 Nov 20 Nov

10:28 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37041/1/src/drivers/uart/oxpcie_ear... File src/drivers/uart/oxpcie_early.c:

https://review.coreboot.org/c/coreboot/+/37041/1/src/drivers/uart/oxpcie_ear... PS1, Line 66: return (oxpcie_present); return is not a function, parentheses are not required

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 21:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10:38 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37041/2/src/drivers/uart/oxpcie_ear... File src/drivers/uart/oxpcie_early.c:

https://review.coreboot.org/c/coreboot/+/37041/2/src/drivers/uart/oxpcie_ear... PS2, Line 66: return (oxpcie_present); return is not a function, parentheses are not required

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 21:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10:58 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37041/3/src/drivers/uart/oxpcie_ear... File src/drivers/uart/oxpcie_early.c:

https://review.coreboot.org/c/coreboot/+/37041/3/src/drivers/uart/oxpcie_ear... PS3, Line 66: return (oxpcie_present); return is not a function, parentheses are not required

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 21:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

21 Nov 21 Nov

12:38 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37041/4/src/drivers/uart/oxpcie_ear... File src/drivers/uart/oxpcie_early.c:

https://review.coreboot.org/c/coreboot/+/37041/4/src/drivers/uart/oxpcie_ear... PS4, Line 66: return (oxpcie_present); return is not a function, parentheses are not required

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Nov 2019 23:38:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

1:50 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37041

to look at the new patch set (#5).

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support

Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/uart/oxpcie_early.c 1 file changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37041/5

HAOUAS Elyes (Code Review)

28 Nov 28 Nov

9:47 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 28 Nov 2019 20:47:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

9:49 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 28 Nov 2019 20:49:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

29 Nov 29 Nov

10:15 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37041 )

Change subject: drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................

drivers/uart/oxpcie_early.c: Drop CAR_GLOBAL_MIGRATION support

Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37041 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/uart/oxpcie_early.c 1 file changed, 3 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/src/drivers/uart/oxpcie_early.c b/src/drivers/uart/oxpcie_early.c index f6b4040..d12b42a 100644 --- a/src/drivers/uart/oxpcie_early.c +++ b/src/drivers/uart/oxpcie_early.c @@ -14,12 +14,11 @@ #include <stdint.h> #include <stddef.h> #include <device/pci_ops.h> -#include <arch/early_variables.h> #include <console/uart.h> #include <device/pci.h> #include <device/pci_def.h>

-static unsigned int oxpcie_present CAR_GLOBAL; +static unsigned int oxpcie_present; static DEVTREE_CONST u32 uart0_base = CONFIG_EARLY_PCI_MMIO_BASE + 0x1000;

int pci_early_device_probe(u8 bus, u8 dev, u32 mmio_base) @@ -58,13 +57,13 @@ reg16 |= PCI_COMMAND_MEMORY; pci_s_write_config16(device, PCI_COMMAND, reg16);

- car_set_var(oxpcie_present, 1); + oxpcie_present = 1; return 0; }

static int oxpcie_uart_active(void) { - return (car_get_var(oxpcie_present)); + return oxpcie_present; }

uintptr_t uart_platform_base(int idx)

-- To view, visit https://review.coreboot.org/c/coreboot/+/37041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibea14a4cfb7285af42a7493742636c8dc8fe0a33 Gerrit-Change-Number: 37041 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1761

days inactive

1770

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Arthur Heymans (Code Review)
build bot (Jenkins) (Code Review)
HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Patrick Georgi (Code Review)