Attention is currently required from: Hung-Te Lin, Shelley Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/68871/comment/24b51707_b9f3c71e
PS2, Line 132: }
@Yu-Ping: I wrote this as a best guess of how I assume it would probably fit together, but I don't know what exactly those MTK structures mean. Can you check if it makes sense like this or if I can adapt it some way to make the densities match up? It would be nice if we could get them directly from the MR values and don't have to fake them from the total size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If34e6857439b6f6ab225344e5b4dd0ff11d8d42a
Gerrit-Change-Number: 68871
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 01:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment