Attention is currently required from: Jérémy Compostella.
Paul Menzel has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85020?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat: Add printk log missing carriage return character
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/85020/comment/30bd84ee_8f42d162?usp... :
PS1, Line 459: Existing
Could you also sent a follow-up to correct this to *Exiting* (no s)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85020?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b5042795acee3e261765ca4c392d15ef7f5ca96
Gerrit-Change-Number: 85020
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Thu, 07 Nov 2024 07:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes