Bill XIE has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0
The Expresscard port should have a one here.
X1 does not have Expresscard slot.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 79: 0x2005
Does it have two flash chips ? It's not clear from the documentation.
No, it has one flash chip, same as x220.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 104: on
What's behind those ports ? One might be for Expresscard.
a wlan card slot, and a USB3 controller.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 173: has_bdc_detection
Does BDC detection properly work ? […]
How to check whether BDC detection works?
-
Bill XIE (Code Review)