Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73391 )
Change subject: soc/intel/xeon_sp: Report platform cpu info
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73391/comment/5d42eec8_63e5722a
PS2, Line 9: know
known
https://review.coreboot.org/c/coreboot/+/73391/comment/5c5db510_cad17dd3
PS2, Line 11:
Maybe add example output?
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/73391/comment/404378b6_59ea5795
PS2, Line 50: 0x806F1
: #define CPUID_SPR_S2 0x806F2
: #define CPUID_SPR_S3 0x806F3
: #define CPUID_SPR_S4 0x806F4
: #define CPUID_SPR_S6 0x806F6
Please use lowercase letters.
File src/soc/intel/xeon_sp/report_platform.c:
https://review.coreboot.org/c/coreboot/+/73391/comment/301af7ef_a6e2136c
PS2, Line 24: i
No need to fix the length?
https://notabs.org/coding/smallIntsBigPenalty.htm
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73391
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c08fb924aad81608f554523432ab6a549b1b75f
Gerrit-Change-Number: 73391
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 02 Mar 2023 15:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment