Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36576 )
Change subject: mb/intel/{i82801gx,x4x}: Don't select ASPM options ......................................................................
mb/intel/{i82801gx,x4x}: Don't select ASPM options
These are likely not properly set up and L1 is not even supported on the desktop variant of the southbridge.
This fixes observed instability on some PCIe GPUs.
Change-Id: I70d3536984342614a6ef04a45bc6591e358e3abe Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/foxconn/g41s-k/Kconfig M src/mainboard/intel/dg41wv/Kconfig M src/mainboard/lenovo/thinkcentre_a58/Kconfig 5 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36576/1
diff --git a/src/mainboard/asrock/g41c-gs/Kconfig b/src/mainboard/asrock/g41c-gs/Kconfig index e7cbf7a..81b0995 100644 --- a/src/mainboard/asrock/g41c-gs/Kconfig +++ b/src/mainboard/asrock/g41c-gs/Kconfig @@ -30,9 +30,6 @@ || BOARD_ASROCK_G41M_VS3_R2_0 select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/asus/p5qpl-am/Kconfig b/src/mainboard/asus/p5qpl-am/Kconfig index 7eee9cd..7cdfea9 100644 --- a/src/mainboard/asus/p5qpl-am/Kconfig +++ b/src/mainboard/asus/p5qpl-am/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/foxconn/g41s-k/Kconfig b/src/mainboard/foxconn/g41s-k/Kconfig index f74fcd6..3597e4c 100644 --- a/src/mainboard/foxconn/g41s-k/Kconfig +++ b/src/mainboard/foxconn/g41s-k/Kconfig @@ -29,9 +29,6 @@ select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select MAINBOARD_HAS_LPC_TPM - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_LIBGFXINIT
diff --git a/src/mainboard/intel/dg41wv/Kconfig b/src/mainboard/intel/dg41wv/Kconfig index 373f6fa..74c7d52 100644 --- a/src/mainboard/intel/dg41wv/Kconfig +++ b/src/mainboard/intel/dg41wv/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_2048 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/lenovo/thinkcentre_a58/Kconfig b/src/mainboard/lenovo/thinkcentre_a58/Kconfig index fc1c6a7..6d8b3dc 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/Kconfig +++ b/src/mainboard/lenovo/thinkcentre_a58/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_SMSC_SMSCSUPERIO select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36576 )
Change subject: mb/intel/{i82801gx,x4x}: Don't select ASPM options ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36576 )
Change subject: mb/intel/{i82801gx,x4x}: Don't select ASPM options ......................................................................
mb/intel/{i82801gx,x4x}: Don't select ASPM options
These are likely not properly set up and L1 is not even supported on the desktop variant of the southbridge.
This fixes observed instability on some PCIe GPUs.
Change-Id: I70d3536984342614a6ef04a45bc6591e358e3abe Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36576 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/foxconn/g41s-k/Kconfig M src/mainboard/intel/dg41wv/Kconfig M src/mainboard/lenovo/thinkcentre_a58/Kconfig 5 files changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/g41c-gs/Kconfig b/src/mainboard/asrock/g41c-gs/Kconfig index e7cbf7a..81b0995 100644 --- a/src/mainboard/asrock/g41c-gs/Kconfig +++ b/src/mainboard/asrock/g41c-gs/Kconfig @@ -30,9 +30,6 @@ || BOARD_ASROCK_G41M_VS3_R2_0 select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/asus/p5qpl-am/Kconfig b/src/mainboard/asus/p5qpl-am/Kconfig index 7eee9cd..7cdfea9 100644 --- a/src/mainboard/asus/p5qpl-am/Kconfig +++ b/src/mainboard/asus/p5qpl-am/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/foxconn/g41s-k/Kconfig b/src/mainboard/foxconn/g41s-k/Kconfig index f74fcd6..3597e4c 100644 --- a/src/mainboard/foxconn/g41s-k/Kconfig +++ b/src/mainboard/foxconn/g41s-k/Kconfig @@ -29,9 +29,6 @@ select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select MAINBOARD_HAS_LPC_TPM - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_LIBGFXINIT
diff --git a/src/mainboard/intel/dg41wv/Kconfig b/src/mainboard/intel/dg41wv/Kconfig index 373f6fa..74c7d52 100644 --- a/src/mainboard/intel/dg41wv/Kconfig +++ b/src/mainboard/intel/dg41wv/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_2048 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/lenovo/thinkcentre_a58/Kconfig b/src/mainboard/lenovo/thinkcentre_a58/Kconfig index fc1c6a7..6d8b3dc 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/Kconfig +++ b/src/mainboard/lenovo/thinkcentre_a58/Kconfig @@ -25,9 +25,6 @@ select SUPERIO_SMSC_SMSCSUPERIO select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)