Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38318 )
Change subject: soc/intel/skylake: Call mainboard ACPI sleep methods ......................................................................
soc/intel/skylake: Call mainboard ACPI sleep methods
Skylake mainboards also can implement ACPI functionality surrounding sleep.
Tested on an Acer Aspire VN7-572G (Skylake-U).
Change-Id: I969d92c7445b01964d92d28b21f6667614ea82e7 Signed-off-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38318 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/skylake/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index d989fb1..6b9dc40 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -3,6 +3,9 @@ /* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl>
+External (_SB.MPTS, MethodObj) +External (_SB.MWAK, MethodObj) + /* * The _PIC method is called by the OS to choose between interrupt * routing via the i8259 interrupt controller or the APIC. @@ -24,11 +27,20 @@
Method (_PTS, 1) { + If (CondRefOf (_SB.MPTS)) + { + _SB.MPTS (Arg0) + } }
/* The _WAK method is called on system wakeup */
Method (_WAK, 1) { + If (CondRefOf (_SB.MWAK)) + { + _SB.MWAK (Arg0) + } + Return (Package (){ 0, 0 }) }