Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38159 )
Change subject: drivers/i2c/i2cmux: Drop unused i2c multiplex ......................................................................
drivers/i2c/i2cmux: Drop unused i2c multiplex
There is no documentation what hardware this was compatible with.
Change-Id: Ie8832f1d7f4ca2bc8121f84b1ee564403cc69026 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/drivers/i2c/i2cmux/Kconfig D src/drivers/i2c/i2cmux/Makefile.inc D src/drivers/i2c/i2cmux/i2cmux.c 3 files changed, 0 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38159/1
diff --git a/src/drivers/i2c/i2cmux/Kconfig b/src/drivers/i2c/i2cmux/Kconfig deleted file mode 100644 index 57bb278..0000000 --- a/src/drivers/i2c/i2cmux/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_I2CMUX - bool diff --git a/src/drivers/i2c/i2cmux/Makefile.inc b/src/drivers/i2c/i2cmux/Makefile.inc deleted file mode 100644 index 64bbdce..0000000 --- a/src/drivers/i2c/i2cmux/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_I2CMUX) += i2cmux.c diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c deleted file mode 100644 index 42b9d31..0000000 --- a/src/drivers/i2c/i2cmux/i2cmux.c +++ /dev/null @@ -1,45 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <device/device.h> -#include <device/smbus.h> - -static void i2cmux_set_link(struct device *dev, unsigned int link) -{ - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - smbus_write_byte(dev, 0x01, 1 << link); // output value - smbus_write_byte(dev, 0x03, 0); // all output - } - } -} - -static struct device_operations i2cmux_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = DEVICE_NOOP, - .scan_bus = scan_smbus, - .set_link = i2cmux_set_link, -}; - -static void enable_dev(struct device *dev) -{ - if (dev->link_list != NULL) - dev->ops = &i2cmux_operations; -} - -struct chip_operations drivers_i2c_i2cmux_ops = { - CHIP_NAME("i2cmux") - .enable_dev = enable_dev, -};
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38159 )
Change subject: drivers/i2c/i2cmux: Drop unused i2c multiplex ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38159 )
Change subject: drivers/i2c/i2cmux: Drop unused i2c multiplex ......................................................................
drivers/i2c/i2cmux: Drop unused i2c multiplex
There is no documentation what hardware this was compatible with.
Change-Id: Ie8832f1d7f4ca2bc8121f84b1ee564403cc69026 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38159 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- D src/drivers/i2c/i2cmux/Kconfig D src/drivers/i2c/i2cmux/Makefile.inc D src/drivers/i2c/i2cmux/i2cmux.c 3 files changed, 0 insertions(+), 48 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/i2c/i2cmux/Kconfig b/src/drivers/i2c/i2cmux/Kconfig deleted file mode 100644 index 57bb278..0000000 --- a/src/drivers/i2c/i2cmux/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_I2CMUX - bool diff --git a/src/drivers/i2c/i2cmux/Makefile.inc b/src/drivers/i2c/i2cmux/Makefile.inc deleted file mode 100644 index 64bbdce..0000000 --- a/src/drivers/i2c/i2cmux/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_I2CMUX) += i2cmux.c diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c deleted file mode 100644 index 42b9d31..0000000 --- a/src/drivers/i2c/i2cmux/i2cmux.c +++ /dev/null @@ -1,45 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <device/device.h> -#include <device/smbus.h> - -static void i2cmux_set_link(struct device *dev, unsigned int link) -{ - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - smbus_write_byte(dev, 0x01, 1 << link); // output value - smbus_write_byte(dev, 0x03, 0); // all output - } - } -} - -static struct device_operations i2cmux_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = DEVICE_NOOP, - .scan_bus = scan_smbus, - .set_link = i2cmux_set_link, -}; - -static void enable_dev(struct device *dev) -{ - if (dev->link_list != NULL) - dev->ops = &i2cmux_operations; -} - -struct chip_operations drivers_i2c_i2cmux_ops = { - CHIP_NAME("i2cmux") - .enable_dev = enable_dev, -};
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)