Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
mb/google/zork: Set FMDFILE for zork family
This change sets FMDFILE for zork family so that coreboot builds pick up the right flash layout.
BUG=b:155990176
Change-Id: Ia1673622ccd14a2ff7bde555ed33d5b51cf4272a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/42106/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 9a2e373..f795c67 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -39,6 +39,10 @@ select HAVE_ACPI_RESUME select DRIVERS_USB_ACPI
+config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" + config MAINBOARD_DIR string default google/zork
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE This is the default, why do we need to set it? https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE
This is the default, why do we need to set it? […]
For builds without CHROMEOS selected, it is using a very different .fmd file.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE
For builds without CHROMEOS selected, it is using a very different .fmd file.
Need to think about this some more. But, I think that check should be changed to MAINBOARD_HAS_CHROMEOS instead of CHROMEOS to use chromeos.fmd.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE
Need to think about this some more. […]
Ah, you are worried about the non chromeos builds. I guess the VPD and GBB are the only things really CHROMEOS specific. The RW_A/B sections are a function of VBOOT which you don't need chromeos for. I'm fine landing this for now. Can you just add a comment so others don't come and remove it like I did :)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE
Ah, you are worried about the non chromeos builds. […]
VPD, GBB - yes. But, also RW_MRC_CACHE.
Hello build bot (Jenkins), Raul Rangel, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42106
to look at the new patch set (#2).
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
mb/google/zork: Set FMDFILE for zork family
This change sets FMDFILE for zork family so that coreboot builds pick up the right flash layout.
BUG=b:155990176
Change-Id: Ia1673622ccd14a2ff7bde555ed33d5b51cf4272a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/42106/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42106/1/src/mainboard/google/zork/K... PS1, Line 42: FMDFILE
VPD, GBB - yes. But, also RW_MRC_CACHE.
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 2: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42106 )
Change subject: mb/google/zork: Set FMDFILE for zork family ......................................................................
mb/google/zork: Set FMDFILE for zork family
This change sets FMDFILE for zork family so that coreboot builds pick up the right flash layout.
BUG=b:155990176
Change-Id: Ia1673622ccd14a2ff7bde555ed33d5b51cf4272a Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42106 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 9a2e373..302ad8b 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -39,6 +39,12 @@ select HAVE_ACPI_RESUME select DRIVERS_USB_ACPI
+# FMDFILE is set here so that coreboot build picks up this flash map layout +# even when CHROMEOS is not selected when building upstream. +config FMDFILE + string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" + config MAINBOARD_DIR string default google/zork
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)