Change in coreboot[master]: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt

List overview All Threads
Download

newer

older

Change in coreboot[4.11_branch]:...

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

23 Jun 2020 23 Jun '20

4:13 a.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt

BUG=b:159187889 BRANCH=none TEST=none

Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/42714/1

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index ededac4..d675954 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -84,6 +84,18 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A Port 4

+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(4) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(4) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Edward O'Callaghan (Code Review)

30 Jun 30 Jun

1:42 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Set Ready For Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 01:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sam McNally (Code Review)

1:50 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 89: 3 We want 1 instead of 3 to cover all the type A ports.

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 95: 4 We want 1 instead of 4 to cover all the type A ports.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 01:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

3:32 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 89: 3

...

We want 1 instead of 3 to cover all the type A ports.

Done

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 95: 4

...

We want 1 instead of 4 to cover all the type A ports.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 03:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

3:32 a.m.

Hello Sam McNally, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42714

to look at the new patch set (#9).

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt

BUG=b:159187889 BRANCH=none TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/42714/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sam McNally (Code Review)

4:09 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 89: 3

...

Done

Sorry, this should be been adding 1 and removing 2. We want 1, 3-6 enabled for USB2.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 04:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

4:16 a.m.

Hello Sam McNally, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42714

to look at the new patch set (#10).

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt

BUG=b:159187889 BRANCH=none TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/42714/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 10 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

4:17 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42714/7/src/mainboard/google/hatch/... PS7, Line 89: 3

...

Sorry, this should be been adding 1 and removing 2. We want 1, 3-6 enabled for USB2.

Ack, I think this is what you want now.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 10 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 04:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org Gerrit-MessageType: comment

Sam McNally (Code Review)

4:33 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 10 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 04:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

9:19 p.m.

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42714 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in dt

BUG=b:159187889 BRANCH=none TEST=none

Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42714 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index ededac4..c78364d 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -84,6 +84,18 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A Port 4

+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(4) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/42714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13626a236f1b7385208c4181150f094cbda490ed Gerrit-Change-Number: 42714 Gerrit-PatchSet: 11 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1554

days inactive

1561

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

Edward O'Callaghan (Code Review)
Sam McNally (Code Review)