Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47966 )
Change subject: arch/ppc64: Remove .id section in bootblock ......................................................................
arch/ppc64: Remove .id section in bootblock
The strings in .id are expected to match the build for the purpose of identifying the binary image. There is no identified use for the offsets.
The files id.ld and prologue.inc were unused.
Change-Id: Ida332671e0ace3f6afd11020474ffda04614bad5 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/ppc64/Kconfig M src/arch/ppc64/bootblock.S D src/arch/ppc64/id.ld D src/arch/ppc64/prologue.inc 4 files changed, 0 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/47966/1
diff --git a/src/arch/ppc64/Kconfig b/src/arch/ppc64/Kconfig index 546dbc8..44dbb1d 100644 --- a/src/arch/ppc64/Kconfig +++ b/src/arch/ppc64/Kconfig @@ -17,7 +17,3 @@ config ARCH_RAMSTAGE_PPC64 bool select ARCH_PPC64 - -config ID_SECTION_OFFSET - hex - default 0x80 diff --git a/src/arch/ppc64/bootblock.S b/src/arch/ppc64/bootblock.S index 8b66fcd..b443f05 100644 --- a/src/arch/ppc64/bootblock.S +++ b/src/arch/ppc64/bootblock.S @@ -8,26 +8,3 @@ .org 0x100, 0xff _start: b _start - .section ".id", "a", %progbits - - .section ".id", "a", @progbits - - .globl __id_start -__id_start: -ver: - .asciz "4" //COREBOOT_VERSION -vendor: - .asciz "qemu" //CONFIG_MAINBOARD_VENDOR -part: - .asciz "1" //CONFIG_MAINBOARD_PART_NUMBER - /* Reverse offset to the vendor id */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - ver - /* Reverse offset to the vendor id */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - vendor - /* Reverse offset to the part number */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - part - /* of this romimage */ -.long CONFIG_ROM_SIZE - .globl __id_end - -__id_end: diff --git a/src/arch/ppc64/id.ld b/src/arch/ppc64/id.ld deleted file mode 100644 index 7449740..0000000 --- a/src/arch/ppc64/id.ld +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -SECTIONS { - . = (0xffffffff - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start) + 1; - .id (.): { - *(.id) - } -} diff --git a/src/arch/ppc64/prologue.inc b/src/arch/ppc64/prologue.inc deleted file mode 100644 index 21f7d49..0000000 --- a/src/arch/ppc64/prologue.inc +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -.section ".rom.data", "a", @progbits -.section ".rom.text", "ax", @progbits
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47966 )
Change subject: arch/ppc64: Remove .id section in bootblock ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47966 )
Change subject: arch/ppc64: Remove .id section in bootblock ......................................................................
arch/ppc64: Remove .id section in bootblock
The strings in .id are expected to match the build for the purpose of identifying the binary image. There is no identified use for the offsets.
The files id.ld and prologue.inc were unused.
Change-Id: Ida332671e0ace3f6afd11020474ffda04614bad5 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47966 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/ppc64/Kconfig M src/arch/ppc64/bootblock.S D src/arch/ppc64/id.ld D src/arch/ppc64/prologue.inc 4 files changed, 0 insertions(+), 39 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/ppc64/Kconfig b/src/arch/ppc64/Kconfig index 546dbc8..44dbb1d 100644 --- a/src/arch/ppc64/Kconfig +++ b/src/arch/ppc64/Kconfig @@ -17,7 +17,3 @@ config ARCH_RAMSTAGE_PPC64 bool select ARCH_PPC64 - -config ID_SECTION_OFFSET - hex - default 0x80 diff --git a/src/arch/ppc64/bootblock.S b/src/arch/ppc64/bootblock.S index 8b66fcd..b443f05 100644 --- a/src/arch/ppc64/bootblock.S +++ b/src/arch/ppc64/bootblock.S @@ -8,26 +8,3 @@ .org 0x100, 0xff _start: b _start - .section ".id", "a", %progbits - - .section ".id", "a", @progbits - - .globl __id_start -__id_start: -ver: - .asciz "4" //COREBOOT_VERSION -vendor: - .asciz "qemu" //CONFIG_MAINBOARD_VENDOR -part: - .asciz "1" //CONFIG_MAINBOARD_PART_NUMBER - /* Reverse offset to the vendor id */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - ver - /* Reverse offset to the vendor id */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - vendor - /* Reverse offset to the part number */ -.long __id_end + CONFIG_ID_SECTION_OFFSET - part - /* of this romimage */ -.long CONFIG_ROM_SIZE - .globl __id_end - -__id_end: diff --git a/src/arch/ppc64/id.ld b/src/arch/ppc64/id.ld deleted file mode 100644 index 7449740..0000000 --- a/src/arch/ppc64/id.ld +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -SECTIONS { - . = (0xffffffff - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start) + 1; - .id (.): { - *(.id) - } -} diff --git a/src/arch/ppc64/prologue.inc b/src/arch/ppc64/prologue.inc deleted file mode 100644 index 21f7d49..0000000 --- a/src/arch/ppc64/prologue.inc +++ /dev/null @@ -1,4 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -.section ".rom.data", "a", @progbits -.section ".rom.text", "ax", @progbits
-
Arthur Heymans (Code Review) -
Hung-Te Lin (Code Review)
-
Kyösti Mälkki (Code Review)