Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 65:
(4 comments)
https://review.coreboot.org/c/coreboot/+/21774/62//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/21774/62//COMMIT_MSG@48 PS62, Line 48: DisplayPort?
FIXME
Done
https://review.coreboot.org/c/coreboot/+/21774/62//COMMIT_MSG@49 PS62, Line 49: VGA BIOS?
FIXME
Done
https://review.coreboot.org/c/coreboot/+/21774/50/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/21774/50/src/mainboard/dell/optiple... PS50, Line 23: : -- For a three-pipe setup, bandwidth is shared between the 2nd and : -- the 3rd pipe. Thus, probe ports that likely have a high-resolution : -- display attached first.
DONE
Done
https://review.coreboot.org/c/coreboot/+/21774/50/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/mainboard.c:
https://review.coreboot.org/c/coreboot/+/21774/50/src/mainboard/dell/optiple... PS50, Line 14:
DONE
Done
-
Christoph Pomaska (Code Review)