Change in coreboot[master]: mb/google/dedede/var/magolor: Add touch screen devices

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor's touch ctrl devices:
elan 6915
elan 5012
raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 27 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/1

diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index 630919f..4d41ba0 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -86,8 +86,8 @@
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x5d on end
    		end
-			chip drivers/i2c/hid
-				register "generic.hid" = ""ELAN9050""
+		        chip drivers/i2c/hid
+				register "generic.hid" = ""ELAN6915""
    			register "generic.desc" = ""ELAN Touchscreen""
    			register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
    			register "generic.probed" = "1"
@@ -101,8 +101,32 @@
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
-				device i2c 10 on end
+				device i2c 15 on end
    		end
+                        chip drivers/i2c/generic
+                                register "hid" = ""ELAN0001""
+                                register "desc" = ""ELAN Touchscreen""
+                                register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+                                register "probed" = "1"
+                                register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+                                register "reset_delay_ms" = "20"
+                                register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+                                register "enable_delay_ms" = "1"
+                                register "has_power_resource" = "1"
+                                device i2c 10 on end
+                        end
+                        chip drivers/i2c/generic
+                                register "hid" = ""RAYD0001""
+                                register "desc" = ""Raydium Touchscreen""
+                                register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+                                register "probed" = "1"
+                                register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+                                register "reset_delay_ms" = "1"
+                                register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+                                register "enable_delay_ms" = "50"
+                                register "has_power_resource" = "1"
+                                device i2c 39 on end
+                        end
    	end # I2C 2
    	device pci 19.0 on
    		chip drivers/i2c/generic

[Ren Kuo (Code Review)]

Ren Kuo has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor's touch ctrl devices:
elan 6915
elan 5012
raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 26 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/2

[Ren Kuo (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor's touch ctrl devices:
elan 6915
elan 5012
raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 25 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/3

[Ren Kuo (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor's touch ctrl devices:
elan 6915
elan 5012
raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 25 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/4

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 4: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45227/4/src/mainboard/google/dedede... 
PS4, Line 127: 				register "has_power_resource" = "1"
disable_gpio_export_in_crs?

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor's touch ctrl devices:
elan 6915
elan 5012
raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 29 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/5

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 5: Code-Review+1

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45227/4/src/mainboard/google/dedede... 
PS4, Line 127: 				register "has_power_resource" = "1"
> disable_gpio_export_in_crs?

done!

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45227/5//COMMIT_MSG@10 
PS5, Line 10: elan 6915
            : elan 5012
            : raydium RM32680
Please make that a list or enumeration.

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#6).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor touch screen ctrl devices:
1)elan 6915
2)elan 5012
3)raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 29 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/6

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45227/5//COMMIT_MSG@10 
PS5, Line 10: elan 6915
            : elan 5012
            : raydium RM32680
> Please make that a list or enumeration.

done.

[Henry Sun (Code Review)]

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 6: Code-Review+1

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#7).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor touch screen ctrl devices:
1)elan 6915
2)elan 5012
3)raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 27 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/7

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 7: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede... 
PS7, Line 104: 				register "hid_desc_reg_offset" = "0x01"
You will need disable_gpio_export_in_crs here as well. Only for ELAN0001 we don't need that.

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45227

to look at the new patch set (#8).

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor touch screen ctrl devices:
1)elan 6915
2)elan 5012
3)raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 28 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45227/8

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede... 
PS7, Line 104: 				register "hid_desc_reg_offset" = "0x01"
> You will need disable_gpio_export_in_crs here as well. Only for ELAN0001 we don't need that.

done!

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 8: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 8: Code-Review+2

[Henry Sun (Code Review)]

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

Patch Set 8: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45227 )

Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................

mb/google/dedede/var/magolor: Add touch screen devices

add the magolor touch screen ctrl devices:
1)elan 6915
2)elan 5012
3)raydium RM32680

BUG=b:166711761
BRANCH=None
TEST=build firmware and verify the touch functions on DUT

Signed-off-by: Ren Kuo 
Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45227
Reviewed-by: Furquan Shaikh 
Reviewed-by: Henry Sun 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 28 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Ren Kuo: Looks good to me, but someone else must approve
  Henry Sun: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index 630919f..9b7f1f4 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -83,11 +83,12 @@
    			register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
    			register "generic.enable_delay_ms" = "12"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x5d on end
    		end
    		chip drivers/i2c/hid
-				register "generic.hid" = ""ELAN9050""
+				register "generic.hid" = ""ELAN6915""
    			register "generic.desc" = ""ELAN Touchscreen""
    			register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
    			register "generic.probed" = "1"
@@ -100,9 +101,35 @@
    			register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
+				device i2c 15 on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0001""
+				register "desc" = ""ELAN Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "enable_delay_ms" = "1"
+				register "has_power_resource" = "1"
    			device i2c 10 on end
    		end
+			chip drivers/i2c/generic
+				register "hid" = ""RAYD0001""
+				register "desc" = ""Raydium Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "reset_delay_ms" = "1"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "enable_delay_ms" = "50"
+				register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
+				device i2c 39 on end
+			end
    	end # I2C 2
    	device pci 19.0 on
    		chip drivers/i2c/generic