Change in coreboot[master]: src/soc/intel/common/itss: Add support to get IRQ configuration for P...
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )
Change subject: src/soc/intel/common/itss: Add support to get IRQ configuration for PCI devices ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34089/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/irq.h:
https://review.coreboot.org/c/coreboot/+/34089/13/src/soc/intel/common/block... PS13, Line 44:
nit: Delete extra blank line
Ack
https://review.coreboot.org/c/coreboot/+/34089/13/src/soc/intel/common/block... File src/soc/intel/common/block/itss/irq.c:
https://review.coreboot.org/c/coreboot/+/34089/13/src/soc/intel/common/block... PS13, Line 34:
Nit: delete extra blank line
Ack
https://review.coreboot.org/c/coreboot/+/34089/13/src/soc/intel/common/block... PS13, Line 99: index++;
Shouldn't this only get incremented if irq_config[index] is populated in the if statement above?
The reason I Kept it out was for the buffer overrun check and return error.
if (!index || index > *num_entries) return -1;
-
Aamir Bohra (Code Review)