Attention is currently required from: Paul Fagerburg, Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52937 )
Change subject: tests: Enable config override for tests ......................................................................
Patch Set 2:
(4 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52937/comment/9f0f41ac_6e92a994 PS1, Line 88: $(eval $(1)-config-file := $(obj)/$(1)/config.h)
I'm confused why this needs to be an eval? I think you can just do […]
Oh, eval is not required. It is here, because I had problems with this assignment at the beginning. :)
https://review.coreboot.org/c/coreboot/+/52937/comment/5687ca75_2dac5d7a PS1, Line 89: $($(1)-config-file): $(TEST_KCONFIG_AUTOHEADER)
nit: Doesn't really need to be a separate line on its own.
Done
https://review.coreboot.org/c/coreboot/+/52937/comment/99b80a8b_99624789 PS1, Line 97: printf '#ifdef %s\n' "$$$$key" >> $$@; \
nit: don't really need the #ifdef wrapper around the #undef
For some reason I was convinced that compiler will report errors when I will use #undef on non-existent symbol. Fixed
https://review.coreboot.org/c/coreboot/+/52937/comment/9605aff1_09eac097 PS1, Line 107: $(TEST_KCONFIG_AUTOHEADER)
Just replace this with $(1)-config-file, then you don't need the extra line above
Done