Attention is currently required from: Raul Rangel, Furquan Shaikh, Julius Werner, Karthik Ramasubramanian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56580 )
Change subject: commonlib/mem_pool: Align allocations to 64b when using CBFS_PRELOAD
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56580/comment/81711c8b_efb492fa
PS3, Line 12: platforms need to change this in the future, we can add a Kconfig.
I'd prefer if you made a Kconfig for this right now (CONFIG_CBFS_CACHE_ALIGN or something like that) […]
+1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d77ffe4411f86c54450305320c9f52ab41a3075
Gerrit-Change-Number: 56580
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 15:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment