Attention is currently required from: Tim Wawrzynczak, Scott Chao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55134 )
Change subject: mb/google/brya: move MIPI camera setting into overridetree
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55134/comment/8538c167_7fe5a0b0
PS1, Line 132: device ref ipu on end
Hmm, probably should, but also we still need to hook up this device's enabled status to the SaIpuEna […]
Ah yes. That will be required too. Dropping this from baseboard/devicetree will set the device state correctly and the SoC code will have to take that into account to set the UPD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e64d078a8e39732ad29443c3b09ca008a7e902f
Gerrit-Change-Number: 55134
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment