Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55069 )
Change subject: lib/bootmem.c: Use only e820 compatible types
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Well, SeaBIOS also expects to find LB_MEM_TABLE entry to proceed to copy_table(), though it's called CB_MEM_TABLE there instead.
IMHO the payloads are at fault in not doing a translation; it was never speficied that LB_MEM_xx entries would match with both the e820 and multiboot specifications.
Ok fair point. I'll try to fixup x86 linux trampoline.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4797ac9dca1a8f43f104654d0e113236205a288a
Gerrit-Change-Number: 55069
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 29 May 2021 17:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment