Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29234 )
Change subject: security/tpm: Add function to measure a region device ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc File src/security/tpm/Makefile.inc:
https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc@51 PS2, Line 51: postcar-srcs += $(VB2_LIB) Add bootblock if not already built in
https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c@231 PS2, Line 231: buf = rdev_mmap_full(rdev); Will fuckup measurements because of memory constraints. See my previous code :)