Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Ian Feng, Kenny Pan, Nick Vaccaro, Rex Chou, Shou-Chieh Hsu, Subrata Banik.
Hello Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Ian Feng, Kenny Pan, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78147?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/nissa/var/craaskov: Remove TOF function
......................................................................
mb/google/nissa/var/craaskov: Remove TOF function
Based on schematics and confirm with EE to remove TOF function.
BUG=b:290891557
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot
Change-Id: I1ae6a6562d87f8da5f41691a7606a1aa10989443
Signed-off-by: Rex Chou rex_chou@compal.corp-partner.google.com
---
M src/mainboard/google/brya/variants/craaskov/gpio.c
M src/mainboard/google/brya/variants/craaskov/overridetree.cb
2 files changed, 13 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/78147/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78147?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ae6a6562d87f8da5f41691a7606a1aa10989443
Gerrit-Change-Number: 78147
Gerrit-PatchSet: 2
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-MessageType: newpatchset