Change in ...coreboot[master]: {mb,sb}: Use get_acpi_table_revision(FADT)

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33428

Change subject: {mb,sb}: Use get_acpi_table_revision(FADT)
......................................................................

{mb,sb}: Use get_acpi_table_revision(FADT)

Change-Id: Id3d7f021a52e08906ae0a3f794756e397601fe96
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/facebook/fbg1701/fadt.c
M src/mainboard/intel/strago/fadt.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/roda/rk9/fadt.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/nvidia/ck804/fadt.c
10 files changed, 10 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/33428/1

diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
index 2067024..845af71 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
@@ -36,7 +36,7 @@
    memset((void *)fadt,0,sizeof(acpi_fadt_t));
    memcpy(header->signature,"FACP",4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id,OEM_ID,6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id,ASLC,4);
diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 2c6a2ec..a609b5d 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -49,7 +49,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c
index 73adfad..60dd5b9 100644
--- a/src/mainboard/facebook/fbg1701/fadt.c
+++ b/src/mainboard/facebook/fbg1701/fadt.c
@@ -24,7 +24,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c
index 9814d1e..2a54254 100644
--- a/src/mainboard/intel/strago/fadt.c
+++ b/src/mainboard/intel/strago/fadt.c
@@ -25,7 +25,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/lenovo/t400/fadt.c
+++ b/src/mainboard/lenovo/t400/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/lenovo/x200/fadt.c
+++ b/src/mainboard/lenovo/x200/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/roda/rk9/fadt.c
+++ b/src/mainboard/roda/rk9/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/amd/sb700/fadt.c b/src/southbridge/amd/sb700/fadt.c
index 4bc3622..4a5746c 100644
--- a/src/southbridge/amd/sb700/fadt.c
+++ b/src/southbridge/amd/sb700/fadt.c
@@ -37,7 +37,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/amd/sb800/fadt.c b/src/southbridge/amd/sb800/fadt.c
index d94ac73..71bdf23 100644
--- a/src/southbridge/amd/sb800/fadt.c
+++ b/src/southbridge/amd/sb800/fadt.c
@@ -37,7 +37,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c
index 6a09661..f6ad479 100644
--- a/src/southbridge/nvidia/ck804/fadt.c
+++ b/src/southbridge/nvidia/ck804/fadt.c
@@ -35,7 +35,7 @@
    memcpy(header->signature, "FACP", 4);
 #ifdef LONG_FADT
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
 #else
    header->length = 0x74;
    header->revision = 1;

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33428 )

Change subject: {mb,sb}: Use get_acpi_table_revision(FADT)
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33428 )

Change subject: {mb,sb}: Use get_acpi_table_revision(FADT)
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33428 )

Change subject: {mb,sb}: Use get_acpi_table_revision(FADT)
......................................................................

Patch Set 2: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33428 )

Change subject: {mb,sb}: Use get_acpi_table_revision(FADT)
......................................................................

{mb,sb}: Use get_acpi_table_revision(FADT)

Change-Id: Id3d7f021a52e08906ae0a3f794756e397601fe96
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33428
Reviewed-by: Angel Pons 
Reviewed-by: Patrick Rudolph 
Reviewed-by: Frans Hendriks 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/facebook/fbg1701/fadt.c
M src/mainboard/intel/strago/fadt.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/roda/rk9/fadt.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/nvidia/ck804/fadt.c
10 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Frans Hendriks: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
index 2067024..845af71 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
@@ -36,7 +36,7 @@
    memset((void *)fadt,0,sizeof(acpi_fadt_t));
    memcpy(header->signature,"FACP",4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id,OEM_ID,6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id,ASLC,4);
diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 2c6a2ec..a609b5d 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -49,7 +49,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c
index 73adfad..60dd5b9 100644
--- a/src/mainboard/facebook/fbg1701/fadt.c
+++ b/src/mainboard/facebook/fbg1701/fadt.c
@@ -24,7 +24,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c
index 9814d1e..2a54254 100644
--- a/src/mainboard/intel/strago/fadt.c
+++ b/src/mainboard/intel/strago/fadt.c
@@ -25,7 +25,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/lenovo/t400/fadt.c
+++ b/src/mainboard/lenovo/t400/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/lenovo/x200/fadt.c
+++ b/src/mainboard/lenovo/x200/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c
index 673791f..e335787 100644
--- a/src/mainboard/roda/rk9/fadt.c
+++ b/src/mainboard/roda/rk9/fadt.c
@@ -29,7 +29,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/amd/sb700/fadt.c b/src/southbridge/amd/sb700/fadt.c
index 4bc3622..4a5746c 100644
--- a/src/southbridge/amd/sb700/fadt.c
+++ b/src/southbridge/amd/sb700/fadt.c
@@ -37,7 +37,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/amd/sb800/fadt.c b/src/southbridge/amd/sb800/fadt.c
index d94ac73..71bdf23 100644
--- a/src/southbridge/amd/sb800/fadt.c
+++ b/src/southbridge/amd/sb800/fadt.c
@@ -37,7 +37,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c
index 6a09661..f6ad479 100644
--- a/src/southbridge/nvidia/ck804/fadt.c
+++ b/src/southbridge/nvidia/ck804/fadt.c
@@ -35,7 +35,7 @@
    memcpy(header->signature, "FACP", 4);
 #ifdef LONG_FADT
    header->length = 244;
-	header->revision = 3;
+	header->revision = get_acpi_table_revision(FADT);
 #else
    header->length = 0x74;
    header->revision = 1;