Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79018?usp=email )
Change subject: soc/amd/common/pci: Add weak impl. of get_pci_routing_table()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79018/comment/9ec53a66_5f047d34 :
PS1, Line 11: and make use of other functions provided therein.
Is this just a temporary change that's going to be removed? Would it be better just to implement an empty function directly in Genoa with the understanding that it needs to be filled in at some point?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79018?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I873a528f02018bf5c6975bbcee8fbc4b123a06f7
Gerrit-Change-Number: 79018
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Dec 2023 18:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment