HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
src: Remove unused 'include <stddef.h>
Also replace it by <stdint.h> when 'stdint' is missing.
Change-Id: Iae1e875b466f8a195653d897efa1b297c61ad0a5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/riscv/arch_timer.c M src/arch/riscv/misaligned.c M src/arch/riscv/smp.c M src/console/printk.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/gadget.c M src/lib/timer_queue.c M src/lib/timestamp.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/zork/variants/dalboz/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/soc/intel/baytrail/northcluster.c M src/soc/intel/baytrail/romstage/pmc.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/braswell/romstage/romstage.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra210/dma.c M src/soc/rockchip/rk3399/display.c M src/southbridge/intel/lynxpoint/pcie.c 20 files changed, 9 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/41912/1
diff --git a/src/arch/riscv/arch_timer.c b/src/arch/riscv/arch_timer.c index 7e9072b..ad678b7 100644 --- a/src/arch/riscv/arch_timer.c +++ b/src/arch/riscv/arch_timer.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <arch/encoding.h> #include <console/console.h> -#include <stddef.h> #include <timer.h> #include <mcall.h>
diff --git a/src/arch/riscv/misaligned.c b/src/arch/riscv/misaligned.c index eff51fc..244081f 100644 --- a/src/arch/riscv/misaligned.c +++ b/src/arch/riscv/misaligned.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <stdint.h> #include <vm.h> #include <arch/exception.h> diff --git a/src/arch/riscv/smp.c b/src/arch/riscv/smp.c index b3e13ff..1d58602 100644 --- a/src/arch/riscv/smp.c +++ b/src/arch/riscv/smp.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <arch/encoding.h> #include <arch/smp/smp.h> #include <arch/smp/spinlock.h> diff --git a/src/console/printk.c b/src/console/printk.c index c5e5f97..4a3de47 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -10,7 +10,6 @@ #include <console/vtxprintf.h> #include <smp/spinlock.h> #include <smp/node.h> -#include <stddef.h> #include <trace.h> #include <timer.h>
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 739e599..3463741 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <console/console.h> #include <console/usb.h> #include <arch/io.h> diff --git a/src/drivers/usb/gadget.c b/src/drivers/usb/gadget.c index 48a83d2..b7aad23 100644 --- a/src/drivers/usb/gadget.c +++ b/src/drivers/usb/gadget.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <console/console.h> #include <string.h>
diff --git a/src/lib/timer_queue.c b/src/lib/timer_queue.c index f368409..badc600 100644 --- a/src/lib/timer_queue.c +++ b/src/lib/timer_queue.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stddef.h> + #include <timer.h>
#define MAX_TIMER_QUEUE_ENTRIES 64 diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index d10b138..e621629 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <stddef.h> #include <stdint.h> #include <console/console.h> #include <cbmem.h> diff --git a/src/mainboard/google/daisy/memory.c b/src/mainboard/google/daisy/memory.c index a5b7d3c..5dc9c3e 100644 --- a/src/mainboard/google/daisy/memory.c +++ b/src/mainboard/google/daisy/memory.c @@ -5,7 +5,6 @@ #include <soc/setup.h> #include <soc/dmc.h> #include <soc/clk.h> -#include <stddef.h>
const struct mem_timings mem_timings[] = { { diff --git a/src/mainboard/google/zork/variants/dalboz/romstage.c b/src/mainboard/google/zork/variants/dalboz/romstage.c index 42e36c4..e903686 100644 --- a/src/mainboard/google/zork/variants/dalboz/romstage.c +++ b/src/mainboard/google/zork/variants/dalboz/romstage.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <stddef.h> +#include <stdint.h> #include <soc/romstage.h> #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/intel/baskingridge/romstage.c b/src/mainboard/intel/baskingridge/romstage.c index a628105..d6b6c1e 100644 --- a/src/mainboard/intel/baskingridge/romstage.c +++ b/src/mainboard/intel/baskingridge/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <stddef.h> #include <arch/romstage.h> #include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> diff --git a/src/soc/intel/baytrail/northcluster.c b/src/soc/intel/baytrail/northcluster.c index 32b1385..9c4b528 100644 --- a/src/soc/intel/baytrail/northcluster.c +++ b/src/soc/intel/baytrail/northcluster.c @@ -5,7 +5,7 @@ #include <device/pci_ids.h> #include <vendorcode/google/chromeos/chromeos.h> #include <acpi/acpi.h> -#include <stddef.h> +#include <stdint.h> #include <soc/iomap.h> #include <soc/iosf.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/romstage/pmc.c b/src/soc/intel/baytrail/romstage/pmc.c index 48a8e71..b4ea555 100644 --- a/src/soc/intel/baytrail/romstage/pmc.c +++ b/src/soc/intel/baytrail/romstage/pmc.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> diff --git a/src/soc/intel/baytrail/romstage/raminit.c b/src/soc/intel/baytrail/romstage/raminit.c index 1d1bd30..c853f35 100644 --- a/src/soc/intel/baytrail/romstage/raminit.c +++ b/src/soc/intel/baytrail/romstage/raminit.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <acpi/acpi.h> #include <assert.h> #include <cbfs.h> diff --git a/src/soc/intel/baytrail/romstage/romstage.c b/src/soc/intel/baytrail/romstage/romstage.c index fa17351..2da7d69 100644 --- a/src/soc/intel/baytrail/romstage/romstage.c +++ b/src/soc/intel/baytrail/romstage/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <arch/io.h> #include <arch/romstage.h> #include <device/mmio.h> diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index 77d13c4..b6b20b9 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <cbmem.h> -#include <stddef.h> +#include <stdint.h> #include <arch/io.h> #include <device/mmio.h> #include <console/console.h> diff --git a/src/soc/nvidia/tegra124/dma.c b/src/soc/nvidia/tegra124/dma.c index a6fa93b..167f4a1 100644 --- a/src/soc/nvidia/tegra124/dma.c +++ b/src/soc/nvidia/tegra124/dma.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> -#include <stddef.h>
struct apb_dma * const apb_dma = (struct apb_dma *)TEGRA_APB_DMA_BASE;
diff --git a/src/soc/nvidia/tegra210/dma.c b/src/soc/nvidia/tegra210/dma.c index db57191..26b64c8 100644 --- a/src/soc/nvidia/tegra210/dma.c +++ b/src/soc/nvidia/tegra210/dma.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> -#include <stddef.h>
struct apb_dma * const apb_dma = (struct apb_dma *)TEGRA_APB_DMA_BASE;
diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index b47fabc..70e8c7c 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -7,7 +7,7 @@ #include <delay.h> #include <edid.h> #include <gpio.h> -#include <stddef.h> +#include <stdint.h> #include <soc/addressmap.h> #include <soc/clock.h> #include <soc/display.h> diff --git a/src/southbridge/intel/lynxpoint/pcie.c b/src/southbridge/intel/lynxpoint/pcie.c index e11a0b7..8a233da 100644 --- a/src/southbridge/intel/lynxpoint/pcie.c +++ b/src/southbridge/intel/lynxpoint/pcie.c @@ -11,7 +11,6 @@ #include <device/pci_ops.h> #include "pch.h" #include <southbridge/intel/common/gpio.h> -#include <stddef.h> #include <stdint.h> #include "chip.h"
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
Abandoned
see 42340
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
Restored
Hello build bot (Jenkins), Philipp Hug, Julius Werner, Patrick Rudolph, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41912
to look at the new patch set (#11).
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
src: Remove unused 'include <stddef.h>
Change-Id: Iae1e875b466f8a195653d897efa1b297c61ad0a5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/riscv/arch_timer.c M src/arch/riscv/misaligned.c M src/arch/riscv/smp.c M src/console/printk.c M src/lib/timer_queue.c M src/lib/timestamp.c M src/mainboard/google/daisy/memory.c M src/mainboard/intel/baskingridge/romstage.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra210/dma.c M src/southbridge/intel/lynxpoint/pcie.c 12 files changed, 1 insertion(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/41912/11
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
Patch Set 12: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Philipp Hug, Julius Werner, Patrick Rudolph, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41912
to look at the new patch set (#13).
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
src: Remove unused 'include <stddef.h>
Change-Id: Iae1e875b466f8a195653d897efa1b297c61ad0a5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/riscv/arch_timer.c M src/arch/riscv/misaligned.c M src/arch/riscv/smp.c M src/console/printk.c M src/lib/timer_queue.c M src/lib/timestamp.c M src/mainboard/google/daisy/memory.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra210/dma.c M src/southbridge/intel/lynxpoint/pcie.c 11 files changed, 1 insertion(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/41912/13
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
Patch Set 15: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41912 )
Change subject: src: Remove unused 'include <stddef.h> ......................................................................
src: Remove unused 'include <stddef.h>
Change-Id: Iae1e875b466f8a195653d897efa1b297c61ad0a5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41912 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/riscv/arch_timer.c M src/arch/riscv/misaligned.c M src/arch/riscv/smp.c M src/console/printk.c M src/lib/timer_queue.c M src/lib/timestamp.c M src/mainboard/google/daisy/memory.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra210/dma.c M src/southbridge/intel/lynxpoint/pcie.c 11 files changed, 1 insertion(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/arch/riscv/arch_timer.c b/src/arch/riscv/arch_timer.c index 7e9072b..ad678b7 100644 --- a/src/arch/riscv/arch_timer.c +++ b/src/arch/riscv/arch_timer.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <arch/encoding.h> #include <console/console.h> -#include <stddef.h> #include <timer.h> #include <mcall.h>
diff --git a/src/arch/riscv/misaligned.c b/src/arch/riscv/misaligned.c index eff51fc..244081f 100644 --- a/src/arch/riscv/misaligned.c +++ b/src/arch/riscv/misaligned.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <stdint.h> #include <vm.h> #include <arch/exception.h> diff --git a/src/arch/riscv/smp.c b/src/arch/riscv/smp.c index b3e13ff..1d58602 100644 --- a/src/arch/riscv/smp.c +++ b/src/arch/riscv/smp.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <arch/encoding.h> #include <arch/smp/smp.h> #include <arch/smp/spinlock.h> diff --git a/src/console/printk.c b/src/console/printk.c index c5e5f97..4a3de47 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -10,7 +10,6 @@ #include <console/vtxprintf.h> #include <smp/spinlock.h> #include <smp/node.h> -#include <stddef.h> #include <trace.h> #include <timer.h>
diff --git a/src/lib/timer_queue.c b/src/lib/timer_queue.c index f368409..badc600 100644 --- a/src/lib/timer_queue.c +++ b/src/lib/timer_queue.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stddef.h> + #include <timer.h>
#define MAX_TIMER_QUEUE_ENTRIES 64 diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index 24d80ea..5121eb8 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <stddef.h> #include <stdint.h> #include <console/console.h> #include <cbmem.h> diff --git a/src/mainboard/google/daisy/memory.c b/src/mainboard/google/daisy/memory.c index a5b7d3c..5dc9c3e 100644 --- a/src/mainboard/google/daisy/memory.c +++ b/src/mainboard/google/daisy/memory.c @@ -5,7 +5,6 @@ #include <soc/setup.h> #include <soc/dmc.h> #include <soc/clk.h> -#include <stddef.h>
const struct mem_timings mem_timings[] = { { diff --git a/src/soc/intel/baytrail/romstage/romstage.c b/src/soc/intel/baytrail/romstage/romstage.c index ddd657a..76aa711 100644 --- a/src/soc/intel/baytrail/romstage/romstage.c +++ b/src/soc/intel/baytrail/romstage/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <arch/io.h> #include <arch/romstage.h> #include <device/mmio.h> diff --git a/src/soc/nvidia/tegra124/dma.c b/src/soc/nvidia/tegra124/dma.c index a6fa93b..167f4a1 100644 --- a/src/soc/nvidia/tegra124/dma.c +++ b/src/soc/nvidia/tegra124/dma.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> -#include <stddef.h>
struct apb_dma * const apb_dma = (struct apb_dma *)TEGRA_APB_DMA_BASE;
diff --git a/src/soc/nvidia/tegra210/dma.c b/src/soc/nvidia/tegra210/dma.c index db57191..26b64c8 100644 --- a/src/soc/nvidia/tegra210/dma.c +++ b/src/soc/nvidia/tegra210/dma.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> -#include <stddef.h>
struct apb_dma * const apb_dma = (struct apb_dma *)TEGRA_APB_DMA_BASE;
diff --git a/src/southbridge/intel/lynxpoint/pcie.c b/src/southbridge/intel/lynxpoint/pcie.c index 7df5ac3..35ce5c47 100644 --- a/src/southbridge/intel/lynxpoint/pcie.c +++ b/src/southbridge/intel/lynxpoint/pcie.c @@ -12,7 +12,6 @@ #include "iobp.h" #include "pch.h" #include <southbridge/intel/common/gpio.h> -#include <stddef.h> #include <stdint.h> #include "chip.h"
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)