Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 17:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/f52ea022_8196a7e7 PS17, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/43909d4e_c21a4fa1 PS17, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/1de78846_cdbe9461 PS17, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/c38e3c05_754c263f PS17, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/180ee129_e781b5b4 PS17, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/53e34b53_42df4c1b PS17, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/0c4837cf_47e1b40d PS17, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/00afc05c_301b7e98 PS17, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/d51074ee_e5e627e6 PS17, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/cc9de17d_dedcd6d7 PS17, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/e4d8c76f_0cd15759 PS17, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/08772b40_45e5f884 PS17, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/49755b31_593874d8 PS17, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/ab4289c0_2e5ba3d6 PS17, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121780): https://review.coreboot.org/c/coreboot/+/52662/comment/71905d00_9b19002a PS17, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)