Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48279 )
Change subject: soc/intel/common: Move CSE Lite driver functionality into romstage
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48279/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48279/2//COMMIT_MSG@10
PS2, Line 10: triggeres
triggers
Ack
https://review.coreboot.org/c/coreboot/+/48279/2//COMMIT_MSG@13
PS2, Line 13: Verified on JSL and TGL platforms
For bookkeeping: did you check how much boot time is saved because of the reset being done earlier?
Plan is to measure delta time between from romstage(after DRAM init) to ramstage(existing code location) when CSE boots from RO on cold reset. This delta will be boot improvement time. I will have latest numbers tomorrow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48279
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fd562a5c6c8501226abbcb68021d9356bcf0b73
Gerrit-Change-Number: 48279
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 21:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment