Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lean Sheng Tan, Nicholas Chin, Nick Vaccaro, Patrick Rudolph, Pranava Y N, Shuo Liu, Subrata Banik, Tarun, Tim Chu.
Hello Angel Pons, Arthur Heymans, Christian Walter, Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Patrick Rudolph, Pranava Y N, Shuo Liu, Subrata Banik, Tarun, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84609?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: soc/intel/mtl to xeon_sp: Explicitly include static.h for config_of_soc ......................................................................
soc/intel/mtl to xeon_sp: Explicitly include static.h for config_of_soc
As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h"), sources that require access to the devicetree should directly include static.h so that it can be removed from device.h, eliminating unnecessary dependencies on static.h for files that only need the types and function declarations in device.h.
Change-Id: I3c118a707dfe7bb8932606f30eae52ef0b4c9efe Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/soc/intel/meteorlake/acpi.c M src/soc/intel/meteorlake/chip.c M src/soc/intel/meteorlake/cpu.c M src/soc/intel/meteorlake/espi.c M src/soc/intel/meteorlake/fsp_params.c M src/soc/intel/meteorlake/pmc.c M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/meteorlake/romstage/fsp_params.c M src/soc/intel/meteorlake/systemagent.c M src/soc/intel/meteorlake/tcss.c M src/soc/intel/pantherlake/acpi.c M src/soc/intel/pantherlake/chip.c M src/soc/intel/pantherlake/cpu.c M src/soc/intel/pantherlake/espi.c M src/soc/intel/pantherlake/fsp_params.c M src/soc/intel/pantherlake/pmc.c M src/soc/intel/pantherlake/pmutil.c M src/soc/intel/pantherlake/romstage/fsp_params.c M src/soc/intel/pantherlake/systemagent.c M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/bootblock/pch.c M src/soc/intel/skylake/chip.c M src/soc/intel/skylake/cpu.c M src/soc/intel/skylake/fadt.c M src/soc/intel/skylake/lpc.c M src/soc/intel/skylake/pmc.c M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/romstage/fsp_params.c M src/soc/intel/skylake/systemagent.c M src/soc/intel/tigerlake/acpi.c M src/soc/intel/tigerlake/bootblock/pch.c M src/soc/intel/tigerlake/chip.c M src/soc/intel/tigerlake/cpu.c M src/soc/intel/tigerlake/espi.c M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/pmc.c M src/soc/intel/tigerlake/pmutil.c M src/soc/intel/tigerlake/romstage/fsp_params.c M src/soc/intel/tigerlake/systemagent.c M src/soc/intel/xeon_sp/acpi.c M src/soc/intel/xeon_sp/cpx/romstage.c M src/soc/intel/xeon_sp/lpc.c M src/soc/intel/xeon_sp/skx/romstage.c M src/soc/intel/xeon_sp/spr/romstage.c 44 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/84609/5