Rajat Jain has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40313 )
Change subject: google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG ......................................................................
google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG
Add a wrapper command for the subject command
Signed-off-by: Rajat Jain rajatja@google.com Change-Id: I29a4021c2ea0d1cbb4a72f56bf2232d8f9c80ac3 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40313/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 8d9c2ac..f455848 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1513,3 +1513,23 @@
return 1; } + + +int google_chromeec_get_keybd_config(struct ec_response_keybd_config *keybd) +{ + struct chromeec_command cmd = { + .cmd_code = EC_CMD_GET_KEYBD_CONFIG, + .cmd_version = 0, + .cmd_data_in = NULL, + .cmd_size_in = 0, + .cmd_data_out = keybd, + .cmd_size_out = sizeof(*keybd), + .cmd_dev_index = 0, + }; + + if (google_chromeec_command(&cmd)) + return -1; + + return 0; +} + diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index f1caeb0..73774f2 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -323,6 +323,14 @@ int google_chromeec_get_pd_port_caps(int port, struct usb_pd_port_caps *port_caps);
+/** + * Get the keyboard configuration / layout information from EC + * + * @param *keybd If successful, this is filled with EC filled parameters + * @return 0 on success, -1 on error + */ +int google_chromeec_get_keybd_config(struct ec_response_keybd_config *keybd); + #if CONFIG(HAVE_ACPI_TABLES) /** * Writes USB Type-C PD related information to the SSDT
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40313
to look at the new patch set (#2).
Change subject: google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG ......................................................................
google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG
Add a wrapper command for the subject command
Signed-off-by: Rajat Jain rajatja@google.com Change-Id: I29a4021c2ea0d1cbb4a72f56bf2232d8f9c80ac3 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40313/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40313 )
Change subject: google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG ......................................................................
Patch Set 2: Code-Review+2
Thanks Rajat!
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40313 )
Change subject: google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG ......................................................................
google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG
Add a wrapper command for the subject command
Signed-off-by: Rajat Jain rajatja@google.com Change-Id: I29a4021c2ea0d1cbb4a72f56bf2232d8f9c80ac3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40313 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 26 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 73baec6..1c1f42e 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1518,3 +1518,21 @@
return 1; } + +int google_chromeec_get_keybd_config(struct ec_response_keybd_config *keybd) +{ + struct chromeec_command cmd = { + .cmd_code = EC_CMD_GET_KEYBD_CONFIG, + .cmd_version = 0, + .cmd_data_in = NULL, + .cmd_size_in = 0, + .cmd_data_out = keybd, + .cmd_size_out = sizeof(*keybd), + .cmd_dev_index = 0, + }; + + if (google_chromeec_command(&cmd)) + return -1; + + return 0; +} diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 64d7e52..5f84722 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -330,6 +330,14 @@ int google_chromeec_get_pd_port_caps(int port, struct usb_pd_port_caps *port_caps);
+/** + * Get the keyboard configuration / layout information from EC + * + * @param *keybd If successful, this is filled with EC filled parameters + * @return 0 on success, -1 on error + */ +int google_chromeec_get_keybd_config(struct ec_response_keybd_config *keybd); + #if CONFIG(HAVE_ACPI_TABLES) /** * Writes USB Type-C PD related information to the SSDT
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40313 )
Change subject: google/chromeec: Add wrapper for EC_CMD_GET_KEYBD_CONFIG ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 1/3/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/2492 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/2491 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2490 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : FAIL : https://lava.9esec.io/r/2489
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Rajat Jain (Code Review)
-
Tim Wawrzynczak (Code Review)