Attention is currently required from: Paul Menzel, Christian Walter, Angel Pons, Lean Sheng Tan.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68783 )
Change subject: mb/prodrive/atlas: Add IBECC Kconfig option ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68783/comment/982a85d5_3996c61e PS2, Line 10: indurance
*e*ndurance
Done
https://review.coreboot.org/c/coreboot/+/68783/comment/cde6d67f_adaa7784 PS2, Line 12: Test: start atlas mainboard with Linux. See in dmesg that IBECC (EDAC igen6) driver is loaded. Inject a fake error via debugfs and see in dmesg that Linux handles it.
Please wrap at 72 characters
Done
File src/mainboard/prodrive/atlas/Kconfig:
https://review.coreboot.org/c/coreboot/+/68783/comment/b8f34591_9146724b PS2, Line 26: indurance
*e*ndurance
Done
https://review.coreboot.org/c/coreboot/+/68783/comment/ea001a6f_155acb9a PS2, Line 27: not always required
Why is it default enabled then?
My bad
File src/mainboard/prodrive/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/68783/comment/acd7d368_80d1df78 PS2, Line 50: ? true : false
This is redundant
Done
-
Maximilian Brune (Code Review)