Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66994
to look at the new patch set (#10).
Change subject: soc/amd: Refactor DPTC Tablet Mode ......................................................................
soc/amd: Refactor DPTC Tablet Mode
Refactor AMD DPTC tablet mode in preparation for adding low/no battery DPTC settings.
1. Refactor and simplify acpigen_write_alib_dptc() into the following functions: - acpigen_write_alib_dptc_default() - acpigen_write_alib_dptc_tablet() 2. Add device tree register value dptc_tablet_mode_enabled to control whether DPTC tablet mode is enabled for a variant. 3. Add dptc.asl to perform the necessary ACPI checking before modifying the DPTC settings.
BRANCH=none BUG=b:217911928 TEST=Build zork TEST=Build nipperkin TEST=Boot skyrim
Change-Id: I2518fdd526868c9d5668a6018fd3570392e809c0 Signed-off-by: Tim Van Patten timvp@google.com --- M src/mainboard/google/zork/variants/morphius/overridetree.cb M src/soc/amd/cezanne/acpi/soc.asl M src/soc/amd/cezanne/chip.h M src/soc/amd/cezanne/root_complex.c A src/soc/amd/common/acpi/dptc.asl M src/soc/amd/common/block/acpi/alib.c M src/soc/amd/common/block/include/amdblocks/alib.h M src/soc/amd/mendocino/Kconfig M src/soc/amd/mendocino/acpi/soc.asl M src/soc/amd/mendocino/chip.h M src/soc/amd/mendocino/root_complex.c M src/soc/amd/picasso/acpi/soc.asl M src/soc/amd/picasso/chip.h M src/soc/amd/picasso/root_complex.c 14 files changed, 162 insertions(+), 49 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/66994/10