[M] Change in coreboot[master]: soc/amd: Refactor DPTC Tablet Mode

[Tim Van Patten (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66994 )

Change subject: soc/amd: Refactor DPTC Tablet Mode
......................................................................

Patch Set 10:

(3 comments)

File src/soc/amd/common/acpi/dptc.asl:

https://review.coreboot.org/c/coreboot/+/66994/comment/6a5fce5e_efa02daa 
PS9, Line 15:
> I understand this as DPTC tablet mode. Otherwise DPTC Default. […]

I don't quite understand the question. The flow is:

- If the method `_SB.DDEF()` doesn't exist, then DPTC is not enabled so return immediatley.
- If the method `_SB.DTAB()` exists and the device is in tablet mode (`TBMD == One`), then enable the tablet mode DPTC settings and return.
- Enable the default DPTC settings via `_SB.DDEF()` (done during boot or when the device goes from tablet mode -> laptop mode).

Is that what you're looking for?

File src/soc/amd/common/block/acpi/alib.c:

https://review.coreboot.org/c/coreboot/+/66994/comment/95320b22_473782b7 
PS9, Line 43: acpigen_pop_len(); /* Method DDEF */
> acpigen_write_method_end();

Done

https://review.coreboot.org/c/coreboot/+/66994/comment/85ceccfa_bf44ae6b 
PS9, Line 45: acpigen_pop_len(); /* Scope _SB */
> acpigen_write_scope_end(); […]

Done