build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29013 )
Change subject: amd/stoneyridge: Rearrange southbridge.h ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 131: #define CG1PLL_SS_STEP_SIZE_DSFRAC_MASK (0xffff << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 133: #define CG1PLL_SS_AMOUNT_DSFRAC_MASK (0xffff << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 136: #define CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK (0xf << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/29013/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 166: #define DEBUG_PORT_MASK (BIT(16) | BIT(17) | (BIT(18)) Macros with complex values should be enclosed in parentheses