Attention is currently required from: Angel Pons, Arthur Heymans, Nico Huber, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64185?usp=email )
Change subject: haswell NRI: Post-process selected timings
......................................................................
Patch Set 5:
(1 comment)
File src/northbridge/intel/haswell/native_raminit/lookup_timings.c:
https://review.coreboot.org/c/coreboot/+/64185/comment/5494072f_57bb5317 :
PS5, Line 9: uint32_t
While I don't expect Haswell to run at more than 65535 MHz, changing this would require refactoring […]
i'd be in favor of keeping this as it is for now and only look into changing this once all other patches have landed. the current code isn't a problem and changing this to uint16_t seems to be a micro-optimization to me that's not worth the trouble it might cause right now
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64185?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id02caf858f75b9e08016762b3aefda282b274386
Gerrit-Change-Number: 64185
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 24 Apr 2024 17:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment